[PATCH] D55147: Exclude non-integral pointers in isBytewiseValue

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

This patch made me curious because I remembered fixing this one.  Turned out that's still a patch we're carrying downstream.  Oops.  :(

The general approach we took here was a bit different.  I don't have a strong preference, but I want to see what you think of the alternate before continuing.

The basic approach we took was two fold: 1) Disallow stores of non-integral types as "legal stores" in the sense of this file, and 2) inhibit formation of geps off of null in an non-integral address space so as to prevent formation of inttoptrs.

What do you think of the merits of the two approaches?  Is there something your approach catches ours doesn't?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55147/new/

https://reviews.llvm.org/D55147