[PATCH] D55147: Exclude non-integral pointers in isBytewiseValue

Cherry Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 30 13:54:09 PST 2018


cherry marked an inline comment as done.
cherry added inline comments.


================
Comment at: include/llvm/Analysis/ValueTracking.h:227
   /// return undef.
-  Value *isBytewiseValue(Value *V);
+  Value *isBytewiseValue(Value *V, const DataLayout &DL = DataLayout(""));
 
----------------
Provided a default value as this function is public so it won't break external uses. External uses probably don't care about non-integral pointer anyway. (E.g. clang has one use.)



Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55147/new/

https://reviews.llvm.org/D55147





More information about the llvm-commits mailing list