[PATCH] D54016: [X86] don't allow X86_64 PIC mode addresses to be used as immediates

Fri Nov 30 21:24:09 PST 2018

rapidsna added a comment.

@rnk Thanks for looking into this.

I'm not sure I understand:

The change I made is inside the function `void X86TargetLowering::LowerAsmOperandForConstraint(`, and under `case 'i': {` which specifically handles operands of the inline assembly constraint `i`. Inside this routine DOES have the PIC checking routine in order not to emit immediates in the case of PIC modes. There already have checks for other PIC styles but RIPRel is missing. So I still believe this is the right place to fix this problem.

I will be happy to have any comment and will soon add the test code.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54016/new/

https://reviews.llvm.org/D54016