[PATCH] D54873: [WebAssembly] Make signature index not a part of EventType

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 30 14:49:24 PST 2018


sbc100 added a comment.

In D54873#1315289 <https://reviews.llvm.org/D54873#1315289>, @aheejin wrote:

> Ping. So the decision points are
>
> 1. Whether `SigIndex` should be in or out of `WasmEventType`?
>   1. If `SigIndex` should be out of `WasmEventType`, should there even be `WasmEventType` anymore? Because then there's only `Attribute` left.
> 2. It seems to be people don't like the term `Attribute`. Should we change it to `Kind` or something? We can change the spec text, because it's not set in stone or anything.


Seems like we should keep the two member WasmEventType.  We need this for specifying the events themselves, and also for importing events.  It seems like this matches WasmGlobalType,

`Attrbiute` does seem like a strange name, but maybe there is reason that was chosen in spec currently?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54873/new/

https://reviews.llvm.org/D54873





More information about the llvm-commits mailing list