[PATCH] D54873: [WebAssembly] Make signature index not a part of EventType

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 30 14:37:45 PST 2018


aheejin added a comment.

Ping. So the decision points are

1. Whether `SigIndex` should be in or out of `WasmEventType`?
  1. If `SigIndex` should be out of `WasmEventType`, should there even be `WasmEventType` anymore? Because then there's only `Attribute' left.
2. It seems to be people don't like the term `Attribute`. Should we change it to `Kind` or something? We can change the spec text, because it's not set in stone or anything.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54873/new/

https://reviews.llvm.org/D54873





More information about the llvm-commits mailing list