[PATCH] D55089: [TableGen] Fix negation of simple predicates

Andrea Di Biagio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 30 12:07:11 PST 2018


andreadb accepted this revision.
andreadb added a comment.
This revision is now accepted and ready to land.

In D55089#1314992 <https://reviews.llvm.org/D55089#1314992>, @evandro wrote:

> I'm all for reusing code, but this is not any sophisticated algorithm, but mere streaming of data.  I rather keep the additional methods and simplify the exiting ones to eliminate their special cases for the sake of maintenance.  After all, complicating them is what resulted in this issue.


Fair enough.

LGTM


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55089/new/

https://reviews.llvm.org/D55089





More information about the llvm-commits mailing list