[PATCH] D55089: [TableGen] Fix negation of simple predicates

Evandro Menezes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 30 11:10:49 PST 2018


evandro added a comment.

I'm all for reusing code, but this is not any sophisticated algorithm, but mere streaming of data.  I rather keep the additional methods and simplify the exiting ones to eliminate their special cases for the sake of maintenance.  After all, complicating them is what resulted in this issue.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55089/new/

https://reviews.llvm.org/D55089





More information about the llvm-commits mailing list