[PATCH] D55091: Add --analyze option to llvm-dwarfdump

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: tools/llvm-dwarfdump/Analyze.cpp:71
+
+raw_ostream &operator<<(raw_ostream &OS, const ReadableFileSize &RFS) {
+  if (RFS.Size < 1024)
----------------
clayborg wrote:
> aprantl wrote:
> > This function should go into `StringExtras.h` or `raw_ostram.h` or somewhere in Support.
> ReadableFileSize is a local class. Format.h seems to be a place where ReadableFileSize could be moved of that is what you were wanting?
Sorry, what I meant to say was: We should have a function in `StringExtras.h` that converts a uint64_t byte size into a human-readable string. The percentage computation is of course better left here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55091/new/

https://reviews.llvm.org/D55091