[PATCH] D55091: Add --analyze option to llvm-dwarfdump

Fri Nov 30 10:15:55 PST 2018

clayborg added a comment.

In D55091#1314919 <https://reviews.llvm.org/D55091#1314919>, @vsk wrote:

> In D55091#1314811 <https://reviews.llvm.org/D55091#1314811>, @clayborg wrote:
>
> > I feel like llvm-dwarfdump is a great place for analyzing DWARF specific information. I did only DWARF section information in llvm-dwarfdump since that is what the tool concentrates on. If llvm-objdump is already correctly identifying information as debug info, I follow David's train of thought where a user might try to figure out which tool can tell me more about debug info and that would lead to llvm-dwarfdump.
> >
> > All of the rest of the information that will be added under the --analyze is DWARF specific and might not make as much sense in llvm-objdump. Though we could put the data gathering for the analysis in the DebugInfo/DWARF folder and allow both tools to report the same things if needed.
>
>
> The problem with having this analysis functionality in llvm-dwarfdump is that it will lead to code duplication and inconsistent tooling down the road.
>
> Your DWARF analysis tool presumably needs to support diffing and output serialization. So would a comprehensive code size analysis tool. There's no reason why these two tools should have different diffing / serialization options. The latter shouldn't live within a debug info specific tool. However, there's no fundamental issue with adding DWARF to the long list of formats llvm-objdump already understands. Technically, it's just a matter of linking in llvm's DWARF libraries.

I am not picky where it lives, just want to run one tool when analyzing if possible.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55091/new/

https://reviews.llvm.org/D55091