[PATCH] D53736: [BTF] Add BTF DebugInfo

[Eric Christopher via llvm-commits]

FWIW I do like the new patch direction and hope to get to this shortly.

On Fri, Nov 30, 2018, 8:51 AM Yonghong Song <yhs at fb.com> wrote:

>
> I will revert it now.
>
> On 11/30/18 8:49 AM, Eric Christopher wrote:
> > So Adrian didn't accept this and it touches code that Alexei doesn't
> > have any real experience (as far as I know) with so it isn't appropriate
> > for you to land this without approval. I understand you've been waiting
> > for a while, but that's not a good enough reason. Please revert for now
> > until we can look.
> >
> > On Fri, Nov 30, 2018, 8:25 AM Phabricator via Phabricator
> > <reviews at reviews.llvm.org <mailto:reviews at reviews.llvm.org>> wrote:
> >
> >     This revision was not accepted when it landed; it landed in state
> >     "Needs Review".
> >     This revision was automatically updated to reflect the committed
> >     changes.
> >     Closed by commit rL347999: [BTF] Add BTF DebugInfo (authored by yhs,
> >     committed by ).
> >
> >     Changed prior to commit:
> >     https://reviews.llvm.org/D53736?vs=174527&id=176133#toc
> >     <
> https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D53736-3Fvs-3D174527-26id-3D176133-23toc&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=oest39Lss5_5lx6NZgWa9qhPYwGcCe2RjWValScV-rw&s=zPdsdNZ1_DF0UBWsU_9yoevmReH_8IqNEs335p6L0gs&e=
> >
> >
> >     Repository:
> >        rL LLVM
> >
> >     CHANGES SINCE LAST ACTION
> >     https://reviews.llvm.org/D53736/new/
> >     <
> https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D53736_new_&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=oest39Lss5_5lx6NZgWa9qhPYwGcCe2RjWValScV-rw&s=OsDyTNnwqfvfxsEmM2PHsDO9fRXyB3fe9fCb2UmxtsY&e=
> >
> >
> >     https://reviews.llvm.org/D53736
> >     <
> https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D53736&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=oest39Lss5_5lx6NZgWa9qhPYwGcCe2RjWValScV-rw&s=YSLbTE6YZuqlk1kytiaV1RA80fKpF4HJU11eMc1gA2Q&e=
> >
> >
> >     Files:
> >        llvm/trunk/include/llvm/BinaryFormat/BTF.def
> >        llvm/trunk/include/llvm/BinaryFormat/BTF.h
> >        llvm/trunk/include/llvm/MC/MCObjectFileInfo.h
> >        llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
> >        llvm/trunk/lib/CodeGen/AsmPrinter/BTFDebug.cpp
> >        llvm/trunk/lib/CodeGen/AsmPrinter/BTFDebug.h
> >        llvm/trunk/lib/CodeGen/AsmPrinter/BTFDebugStub.cpp
> >        llvm/trunk/lib/CodeGen/AsmPrinter/CMakeLists.txt
> >        llvm/trunk/lib/CodeGen/AsmPrinter/DebugHandlerBase.cpp
> >        llvm/trunk/lib/CodeGen/AsmPrinter/DebugHandlerBase.h
> >        llvm/trunk/lib/MC/MCObjectFileInfo.cpp
> >        llvm/trunk/test/DebugInfo/BTF/array-1d-char.ll
> >        llvm/trunk/test/DebugInfo/BTF/array-1d-int.ll
> >        llvm/trunk/test/DebugInfo/BTF/array-2d-int.ll
> >        llvm/trunk/test/DebugInfo/BTF/array-size-0.ll
> >        llvm/trunk/test/DebugInfo/BTF/array-typedef.ll
> >        llvm/trunk/test/DebugInfo/BTF/binary-format.ll
> >        llvm/trunk/test/DebugInfo/BTF/char.ll
> >        llvm/trunk/test/DebugInfo/BTF/enum-basic.ll
> >        llvm/trunk/test/DebugInfo/BTF/func-func-ptr.ll
> >        llvm/trunk/test/DebugInfo/BTF/func-non-void.ll
> >        llvm/trunk/test/DebugInfo/BTF/func-source.ll
> >        llvm/trunk/test/DebugInfo/BTF/func-typedef.ll
> >        llvm/trunk/test/DebugInfo/BTF/func-unused-arg.ll
> >        llvm/trunk/test/DebugInfo/BTF/func-void.ll
> >        llvm/trunk/test/DebugInfo/BTF/fwd-no-define.ll
> >        llvm/trunk/test/DebugInfo/BTF/fwd-with-define.ll
> >        llvm/trunk/test/DebugInfo/BTF/int.ll
> >        llvm/trunk/test/DebugInfo/BTF/lit.local.cfg
> >        llvm/trunk/test/DebugInfo/BTF/longlong.ll
> >        llvm/trunk/test/DebugInfo/BTF/ptr-const-void.ll
> >        llvm/trunk/test/DebugInfo/BTF/ptr-func-1.ll
> >        llvm/trunk/test/DebugInfo/BTF/ptr-func-2.ll
> >        llvm/trunk/test/DebugInfo/BTF/ptr-func-3.ll
> >        llvm/trunk/test/DebugInfo/BTF/ptr-int.ll
> >        llvm/trunk/test/DebugInfo/BTF/ptr-void.ll
> >        llvm/trunk/test/DebugInfo/BTF/ptr-volatile-const-void.ll
> >        llvm/trunk/test/DebugInfo/BTF/ptr-volatile-void.ll
> >        llvm/trunk/test/DebugInfo/BTF/restrict-ptr.ll
> >        llvm/trunk/test/DebugInfo/BTF/short.ll
> >        llvm/trunk/test/DebugInfo/BTF/struct-anon.ll
> >        llvm/trunk/test/DebugInfo/BTF/struct-basic.ll
> >        llvm/trunk/test/DebugInfo/BTF/struct-bitfield-typedef.ll
> >        llvm/trunk/test/DebugInfo/BTF/struct-enum.ll
> >        llvm/trunk/test/DebugInfo/BTF/uchar.ll
> >        llvm/trunk/test/DebugInfo/BTF/uint.ll
> >        llvm/trunk/test/DebugInfo/BTF/ulonglong.ll
> >        llvm/trunk/test/DebugInfo/BTF/union-array-typedef.ll
> >        llvm/trunk/test/DebugInfo/BTF/ushort.ll
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181130/ff0945dc/attachment.html>