FWIW I do like the new patch direction and hope to get to this shortly. <br><br><div class="gmail_quote"><div dir="ltr">On Fri, Nov 30, 2018, 8:51 AM Yonghong Song <<a href="mailto:yhs@fb.com">yhs@fb.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
I will revert it now.<br>
<br>
On 11/30/18 8:49 AM, Eric Christopher wrote:<br>
> So Adrian didn't accept this and it touches code that Alexei doesn't <br>
> have any real experience (as far as I know) with so it isn't appropriate <br>
> for you to land this without approval. I understand you've been waiting <br>
> for a while, but that's not a good enough reason. Please revert for now <br>
> until we can look.<br>
> <br>
> On Fri, Nov 30, 2018, 8:25 AM Phabricator via Phabricator <br>
> <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a> <mailto:<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>>> wrote:<br>
> <br>
> This revision was not accepted when it landed; it landed in state<br>
> "Needs Review".<br>
> This revision was automatically updated to reflect the committed<br>
> changes.<br>
> Closed by commit rL347999: [BTF] Add BTF DebugInfo (authored by yhs,<br>
> committed by ).<br>
> <br>
> Changed prior to commit:<br>
> <a href="https://reviews.llvm.org/D53736?vs=174527&id=176133#toc" rel="noreferrer" target="_blank">https://reviews.llvm.org/D53736?vs=174527&id=176133#toc</a><br>
> <<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D53736-3Fvs-3D174527-26id-3D176133-23toc&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=oest39Lss5_5lx6NZgWa9qhPYwGcCe2RjWValScV-rw&s=zPdsdNZ1_DF0UBWsU_9yoevmReH_8IqNEs335p6L0gs&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D53736-3Fvs-3D174527-26id-3D176133-23toc&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=oest39Lss5_5lx6NZgWa9qhPYwGcCe2RjWValScV-rw&s=zPdsdNZ1_DF0UBWsU_9yoevmReH_8IqNEs335p6L0gs&e=</a>><br>
> <br>
> Repository:<br>
> rL LLVM<br>
> <br>
> CHANGES SINCE LAST ACTION<br>
> <a href="https://reviews.llvm.org/D53736/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D53736/new/</a><br>
> <<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D53736_new_&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=oest39Lss5_5lx6NZgWa9qhPYwGcCe2RjWValScV-rw&s=OsDyTNnwqfvfxsEmM2PHsDO9fRXyB3fe9fCb2UmxtsY&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D53736_new_&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=oest39Lss5_5lx6NZgWa9qhPYwGcCe2RjWValScV-rw&s=OsDyTNnwqfvfxsEmM2PHsDO9fRXyB3fe9fCb2UmxtsY&e=</a>><br>
> <br>
> <a href="https://reviews.llvm.org/D53736" rel="noreferrer" target="_blank">https://reviews.llvm.org/D53736</a><br>
> <<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D53736&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=oest39Lss5_5lx6NZgWa9qhPYwGcCe2RjWValScV-rw&s=YSLbTE6YZuqlk1kytiaV1RA80fKpF4HJU11eMc1gA2Q&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D53736&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=oest39Lss5_5lx6NZgWa9qhPYwGcCe2RjWValScV-rw&s=YSLbTE6YZuqlk1kytiaV1RA80fKpF4HJU11eMc1gA2Q&e=</a>><br>
> <br>
> Files:<br>
> llvm/trunk/include/llvm/BinaryFormat/BTF.def<br>
> llvm/trunk/include/llvm/BinaryFormat/BTF.h<br>
> llvm/trunk/include/llvm/MC/MCObjectFileInfo.h<br>
> llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp<br>
> llvm/trunk/lib/CodeGen/AsmPrinter/BTFDebug.cpp<br>
> llvm/trunk/lib/CodeGen/AsmPrinter/BTFDebug.h<br>
> llvm/trunk/lib/CodeGen/AsmPrinter/BTFDebugStub.cpp<br>
> llvm/trunk/lib/CodeGen/AsmPrinter/CMakeLists.txt<br>
> llvm/trunk/lib/CodeGen/AsmPrinter/DebugHandlerBase.cpp<br>
> llvm/trunk/lib/CodeGen/AsmPrinter/DebugHandlerBase.h<br>
> llvm/trunk/lib/MC/MCObjectFileInfo.cpp<br>
> llvm/trunk/test/DebugInfo/BTF/array-1d-char.ll<br>
> llvm/trunk/test/DebugInfo/BTF/array-1d-int.ll<br>
> llvm/trunk/test/DebugInfo/BTF/array-2d-int.ll<br>
> llvm/trunk/test/DebugInfo/BTF/array-size-0.ll<br>
> llvm/trunk/test/DebugInfo/BTF/array-typedef.ll<br>
> llvm/trunk/test/DebugInfo/BTF/binary-format.ll<br>
> llvm/trunk/test/DebugInfo/BTF/char.ll<br>
> llvm/trunk/test/DebugInfo/BTF/enum-basic.ll<br>
> llvm/trunk/test/DebugInfo/BTF/func-func-ptr.ll<br>
> llvm/trunk/test/DebugInfo/BTF/func-non-void.ll<br>
> llvm/trunk/test/DebugInfo/BTF/func-source.ll<br>
> llvm/trunk/test/DebugInfo/BTF/func-typedef.ll<br>
> llvm/trunk/test/DebugInfo/BTF/func-unused-arg.ll<br>
> llvm/trunk/test/DebugInfo/BTF/func-void.ll<br>
> llvm/trunk/test/DebugInfo/BTF/fwd-no-define.ll<br>
> llvm/trunk/test/DebugInfo/BTF/fwd-with-define.ll<br>
> llvm/trunk/test/DebugInfo/BTF/int.ll<br>
> llvm/trunk/test/DebugInfo/BTF/lit.local.cfg<br>
> llvm/trunk/test/DebugInfo/BTF/longlong.ll<br>
> llvm/trunk/test/DebugInfo/BTF/ptr-const-void.ll<br>
> llvm/trunk/test/DebugInfo/BTF/ptr-func-1.ll<br>
> llvm/trunk/test/DebugInfo/BTF/ptr-func-2.ll<br>
> llvm/trunk/test/DebugInfo/BTF/ptr-func-3.ll<br>
> llvm/trunk/test/DebugInfo/BTF/ptr-int.ll<br>
> llvm/trunk/test/DebugInfo/BTF/ptr-void.ll<br>
> llvm/trunk/test/DebugInfo/BTF/ptr-volatile-const-void.ll<br>
> llvm/trunk/test/DebugInfo/BTF/ptr-volatile-void.ll<br>
> llvm/trunk/test/DebugInfo/BTF/restrict-ptr.ll<br>
> llvm/trunk/test/DebugInfo/BTF/short.ll<br>
> llvm/trunk/test/DebugInfo/BTF/struct-anon.ll<br>
> llvm/trunk/test/DebugInfo/BTF/struct-basic.ll<br>
> llvm/trunk/test/DebugInfo/BTF/struct-bitfield-typedef.ll<br>
> llvm/trunk/test/DebugInfo/BTF/struct-enum.ll<br>
> llvm/trunk/test/DebugInfo/BTF/uchar.ll<br>
> llvm/trunk/test/DebugInfo/BTF/uint.ll<br>
> llvm/trunk/test/DebugInfo/BTF/ulonglong.ll<br>
> llvm/trunk/test/DebugInfo/BTF/union-array-typedef.ll<br>
> llvm/trunk/test/DebugInfo/BTF/ushort.ll<br>
> <br>
</blockquote></div>