[PATCH] D54674: [llvm-objcopy] First bits for MachO

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap marked an inline comment as done.
alexshap added inline comments.


================
Comment at: tools/llvm-objcopy/MachO/Object.h:200
+  /// The index of LC_SYMTAB load command if present.
+  Optional<size_t> SymTabCommandIndex;
+  /// The index of LC_DYLD_INFO or LC_DYLD_INFO_ONLY load command if present.
----------------
jakehehrlich wrote:
> For indexes would it be better to use uint64_t instead of size_t?
MachO header (even for 64 bit) uses uint32_t for the total size of load commands => the number of load commands can not be greater than uint32_t either.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54674/new/

https://reviews.llvm.org/D54674