[PATCH] D54674: [llvm-objcopy] First bits for MachO

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap marked an inline comment as done.
alexshap added inline comments.


================
Comment at: tools/llvm-objcopy/MachO/MachOObjcopy.cpp:21
+  MachOReader Reader(In);
+  std::unique_ptr<Object> O = Reader.create();
+  assert(O && "Unable to deserialize MachO object");
----------------
jakehehrlich wrote:
> Where is Object forward declared to make this valid?
both MachOReader.h and MachOWriter.h need the definition of the class Object (since they access its methods/fields), Object.h propagates to this file through those headers. Probably, I'd be better no to rely on it and include Object.h explicitly, will do.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54674/new/

https://reviews.llvm.org/D54674