[PATCH] D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending

Thu Nov 29 17:49:40 PST 2018

void added a comment.

In D54125#1313855 <https://reviews.llvm.org/D54125#1313855>, @pirama wrote:

> In D54125#1313836 <https://reviews.llvm.org/D54125#1313836>, @void wrote:
>
> > Hi @piramam,
> >
> > This change is breaking the Linux ThinLTO build. I'll work to get you a test case. Could you revert this patch until we can resolve the issue?
>
>
> This patch fixed a longstanding break with ThinLTO + PGO + LLD.  If the current issue is easy to fix, I'd prefer to fix forward rather than revert this patch.  Can you share details on what fails - error message or crash?
>
> But ultimately, this is @tejohnson's call to revert or fix forward.

That's fine with me. I have an example that I'll attach here. If it's going to take too long, then maybe revert? But it's up to you and @tejohnson.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54125/new/

https://reviews.llvm.org/D54125