[PATCH] D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending

[Pirama Arumuga Nainar via Phabricator via llvm-commits]

pirama added a comment.

In D54125#1313836 <https://reviews.llvm.org/D54125#1313836>, @void wrote:

> Hi @piramam,
>
> This change is breaking the Linux ThinLTO build. I'll work to get you a test case. Could you revert this patch until we can resolve the issue?


This patch fixed a longstanding break with ThinLTO + PGO + LLD.  If the current issue is easy to fix, I'd prefer to fix forward rather than revert this patch.  Can you share details on what fails - error message or crash?

But ultimately, this is @tejohnson's call to revert or fix forward.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54125/new/

https://reviews.llvm.org/D54125