[PATCH] D55047: [ThinLTO] Import local variables from the same module as caller

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson marked an inline comment as done.
tejohnson added inline comments.


================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:304
+      return GlobalValue::isLocalLinkage(RefSummary->linkage()) &&
+             VI.getSummaryList().size() > 1 &&
+             RefSummary->modulePath() != Summary.modulePath();
----------------
evgeny777 wrote:
> Why do you need to check for `VI.getSummaryList().size() > 1`? New test cases are passing without it.
It's probably unnecessary in this context. I had copied this handling from similar code for functions in selectCallee, but there you can have references to locals in another module via indirect call profiles which doesn't apply here. I can go ahead and remove it here.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55047/new/

https://reviews.llvm.org/D55047