[PATCH] D55047: [ThinLTO] Import local variables from the same module as caller

Eugene Leviant via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 29 04:41:49 PST 2018


evgeny777 added inline comments.


================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:304
+      return GlobalValue::isLocalLinkage(RefSummary->linkage()) &&
+             VI.getSummaryList().size() > 1 &&
+             RefSummary->modulePath() != Summary.modulePath();
----------------
Why do you need to check for `VI.getSummaryList().size() > 1`? New test cases are passing without it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55047/new/

https://reviews.llvm.org/D55047





More information about the llvm-commits mailing list