[PATCH] D55020: [llvm-rc] Support EXSTYLE statement.

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 29 00:36:02 PST 2018


mstorsjo added a comment.

Looks great in general, but I think I agree that having it named `ExStyle` would be less prone to confusion.



================
Comment at: tools/llvm-rc/ResourceVisitor.h:53
   virtual Error visitStyleStmt(const StyleStmt *) = 0;
+  virtual Error visitExtStyleStmt(const ExtStyleStmt *) = 0;
   virtual Error visitVersionStmt(const VersionStmt *) = 0;
----------------
These were alpabetically ordered before. The same goes for a few other places in the patch as well.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55020/new/

https://reviews.llvm.org/D55020





More information about the llvm-commits mailing list