[PATCH] D55020: [llvm-rc] Support EXSTYLE statement.

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 28 23:26:50 PST 2018


phosek added a comment.

LGTM although you may want to get a review from someone who's more familiar with `llvm-rc`.



================
Comment at: tools/llvm-rc/ResourceScriptStmt.h:872
+// Ref: docs.microsoft.com/en-us/windows/desktop/menurc/exstyle-statement
+class ExtStyleStmt : public OptionalStmt {
+public:
----------------
Nit: I'd consider naming it just `ExStyle` to match the name of the statement precisely.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55020/new/

https://reviews.llvm.org/D55020





More information about the llvm-commits mailing list