[PATCH] D54713: [SCEV] Guard movement of insertion point for loop-invariants

[Serguei Katkov via Phabricator via llvm-commits]

skatkov added a comment.

In D54713#1312442 <https://reviews.llvm.org/D54713#1312442>, @wristow wrote:

> @skatkov: About the loop unswitching suggestion, that sounds like a fine idea to me.  But definitely outside the scope of this fix.


Absolutely agreed. It was just a sid comment.

>   (As an aside, other than a compiler-crash during vectorization (due to a deref of a null pointer), this is my first experience in the llvm vectorizer.  So I'm not familiar with how to go about adding the improvement you suggested. 

I'm not sure whether you use a custom pipeline or not. But my point was that code came to vectorization pass seems strange because trivial loop unswitch optimization (provided by LoopUnswitch pass) could hoist the invariant check. By some reason it did not happen.

> It's experience I'd like to gain, so I'll consider it as possible future work.  But to make sure I'm not misleading you, I don't have time to work on this in the immediate future.)

Not a problem at all.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54713/new/

https://reviews.llvm.org/D54713