[PATCH] D54713: [SCEV] Guard movement of insertion point for loop-invariants

[Warren Ristow via Phabricator via llvm-commits]

wristow added a comment.

@mkazantsev: Thanks for clarifying about the Unit test approach.  I'll create a Unit test to check on the non-preheader case as a followup commit.

@skatkov: About the loop unswitching suggestion, that sounds like a fine idea to me.  But definitely outside the scope of this fix.  (As an aside, other than a compiler-crash during vectorization (due to a deref of a null pointer), this is my first experience in the llvm vectorizer.  So I'm not familiar with how to go about adding the improvement you suggested.  It's experience I'd like to gain, so I'll consider it as possible future work.  But to make sure I'm not misleading you, I don't have time to work on this in the immediate future.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54713/new/

https://reviews.llvm.org/D54713