[PATCH] D53945: [TextAPI] TBD Reader/Writer

Juergen Ributzka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 28 12:27:14 PST 2018


ributzka added a comment.

In D53945#1310580 <https://reviews.llvm.org/D53945#1310580>, @jakehehrlich wrote:

> Would there be an objection to using llvm::tapi::MachO or llvm::tapi::macho? At least for ELF it doesn't make much sense to put the tapi code in the same namespace as BinaryFormat/ELF so it would be nice to add the extra namespace. I'm not married to the idea however.


I see and use tapi as a top-level namespace for the tapi tool, so it feels weird to have that namespace also as a nested namespace inside llvm.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53945/new/

https://reviews.llvm.org/D53945





More information about the llvm-commits mailing list