[PATCH] D53945: [TextAPI] TBD Reader/Writer

[Juergen Ributzka via Phabricator via llvm-commits]

ributzka marked an inline comment as done.
ributzka added inline comments.


================
Comment at: llvm/lib/TextAPI/MachO/TextStub.cpp:188-196
+inline Flags operator|(const Flags a, const Flags b) {
+  return static_cast<Flags>(static_cast<unsigned>(a) |
+                            static_cast<unsigned>(b));
+}
+
+inline Flags operator|=(Flags &a, const Flags b) {
+  a = static_cast<Flags>(static_cast<unsigned>(a) | static_cast<unsigned>(b));
----------------
lhames wrote:
> You might be able to use llvm/ADT/BitmaskEnum.h here, rather than defining these operators yourself.
Sweet. I didn't know we had this. This cleaned up the code in several files.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53945/new/

https://reviews.llvm.org/D53945