[PATCH] D54924: [WebAssembly] Check if the section order is correct

Wed Nov 28 08:49:08 PST 2018

sbc100 added a comment.

In D54924#1310780 <https://reviews.llvm.org/D54924#1310780>, @aheejin wrote:

> D44024 <https://reviews.llvm.org/D44024> is not simpler; actually it is more complicated because it checks more things than this, such as custom sections and whether the function section matches with the code section. If you think we should also include custom section checking in this CL, why don't we just land D44024 <https://reviews.llvm.org/D44024>?

Sure I'd be happy to see D44024 <https://reviews.llvm.org/D44024> resurrected.  I'll ping ncw@ and see if he has cycles to do that.

> The reason I added that in `BinaryFormat` is it uses `wasm` namespace while `Object` uses `object` namespace. I wanted put `isValidSectionOrder` function within `wasm` namespace.

Right, but there is plenty of wasm-speciifc code in the `object` namespace.  The code for wasm object file parsing, etc all lives in the object::WasmObjectFile() class.  Its not clear to me in this case what the best home for such a function is.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54924/new/

https://reviews.llvm.org/D54924