[PATCH] D54924: [WebAssembly] Check if the section order is correct

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 27 18:26:39 PST 2018


aheejin added a comment.

D44024 <https://reviews.llvm.org/D44024> is not simpler; actually it is more complicated because it checks more things than this, such as custom sections and whether the function section matches with the code section. If you think we should also include custom section checking in this CL, why don't we just land D44024 <https://reviews.llvm.org/D44024>?

The reason I added that in `BinaryFormat` is it uses `wasm` namespace while `Object` uses `object` namespace. I wanted put `isValidSectionOrder` function within `wasm` namespace.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54924/new/

https://reviews.llvm.org/D54924





More information about the llvm-commits mailing list