[llvm] r294500 - [DebugInfo] Rename EmitDebugValue to EmitDebugThreadLocal (NFC)

[Adrian Prantl via llvm-commits]

> On Nov 27, 2018, at 4:04 PM, David Blaikie <dblaikie at gmail.com> wrote:
> 
> (+Adrian and Paul in case they have any particular thoughts/context here)
> 
> Honestly I have no state here, two years later. Looking at the code, seems DwarfCompileUnit::addExpr is only used for TLS, but DwarfCompileUnit::addAddressExpr (the other use of DIEExpr) is used for PCOffset, which is created in DebugHandlerBase::getFunctionLocalOffsetAfterInsn - which doesn't have anything to do with thread locals. So, sure, guess it could be renamed back?

If it is used in the non-TLS code, then renaming it seems reasonable, sure.

-- adrian

> 
> On Wed, Nov 21, 2018 at 1:55 PM Simon Atanasyan <simon at atanasyan.com <mailto:simon at atanasyan.com>> wrote:
> Hi David,
> 
> Commit message for the r294500 states that "As pointed out by David
> Blaikie in the post commit review of r292624, EmitDebugValue should be
> called EmitDebugThreadLocal".
> 
> After that commit the `DIEExpr::EmitValue` always calls the
> `EmitDebugThreadLocal` for all architectures. Is it true that _any_
> DIE expression is related to thread local storage on _all_
> architectures?
> 
> Regards,
> Simon

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181127/e26e1a78/attachment.html>