<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Nov 27, 2018, at 4:04 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">(+Adrian and Paul in case they have any particular thoughts/context here)<br class=""><br class="">Honestly I have no state here, two years later. Looking at the code, seems DwarfCompileUnit::addExpr is only used for TLS, but DwarfCompileUnit::addAddressExpr (the other use of DIEExpr) is used for PCOffset, which is created in DebugHandlerBase::getFunctionLocalOffsetAfterInsn - which doesn't have anything to do with thread locals. So, sure, guess it could be renamed back?<br class=""></div></div></blockquote><div><br class=""></div><div>If it is used in the non-TLS code, then renaming it seems reasonable, sure.</div><div><br class=""></div><div>-- adrian</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Wed, Nov 21, 2018 at 1:55 PM Simon Atanasyan <<a href="mailto:simon@atanasyan.com" class="">simon@atanasyan.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi David,<br class="">
<br class="">
Commit message for the r294500 states that "As pointed out by David<br class="">
Blaikie in the post commit review of r292624, EmitDebugValue should be<br class="">
called EmitDebugThreadLocal".<br class="">
<br class="">
After that commit the `DIEExpr::EmitValue` always calls the<br class="">
`EmitDebugThreadLocal` for all architectures. Is it true that _any_<br class="">
DIE expression is related to thread local storage on _all_<br class="">
architectures?<br class="">
<br class="">
Regards,<br class="">
Simon<br class="">
</blockquote></div></div>
</div></blockquote></div><br class=""></body></html>