[PATCH] D53051: [llvm-tapi] initial commit, supports ELF text stubs

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 27 15:11:13 PST 2018


jakehehrlich added a comment.

Oh and you'll need to remove the dependency on libObject as discussed. I pointed out that only changes I think you'll need to make but you might find a few more.



================
Comment at: llvm/include/llvm/TextAPI/ELF/ELFStub.h:18
+
+#include "llvm/Object/ELF.h"
+#include "llvm/Support/VersionTuple.h"
----------------
Use BinaryFormat


================
Comment at: llvm/lib/TextAPI/LLVMBuild.txt:22
+parent = Libraries
+required_libraries = Object Support BinaryFormat
----------------
Make sure to remove this as well.


================
Comment at: llvm/unittests/TextAPI/ELFYAMLTest.cpp:11
+#include "llvm/ADT/StringRef.h"
+#include "llvm/Object/ELF.h"
+#include "llvm/TextAPI/ELF/ELFStub.h"
----------------
And this.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53051/new/

https://reviews.llvm.org/D53051





More information about the llvm-commits mailing list