[PATCH] D53051: [llvm-tapi] initial commit, supports ELF text stubs

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 27 15:07:23 PST 2018


jakehehrlich added a comment.

LGTM with nits. Please make sure Jurgen and you agree on the namespace and folder scheme first but other than than this LGTM.



================
Comment at: llvm/include/llvm/TextAPI/ELF/ELFStub.h:49
+// Both textual and binary stubs will read into and write from this object.
+class ELFStub {
+public:
----------------
Please add a TODO for symbol versioning.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53051/new/

https://reviews.llvm.org/D53051





More information about the llvm-commits mailing list