[PATCH] D54891: [RFC] Checking inline assembly for validity

[Oliver Stannard via Phabricator via llvm-commits]

olista01 marked an inline comment as done.
olista01 added a comment.

For the first example, it looks like we're missing the case where a memory instruction with writeback modifies the address register. I'll have a look and see if there's a way to fix that.

For the second example, I've only made the assembly parser modifications for ARM so far, so I would't expect this to work for X86 yet.



================
Comment at: include/llvm/MC/MCInstrDesc.h:612
+    // Varidaic definition.
+    if (OpIdx >= (NumOperands - 1) && variadicOpsAreDefs())
+      return true;
----------------
glandium wrote:
> Where does `variadicOpsAreDefs` come from?
That's added by D54853.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54891/new/

https://reviews.llvm.org/D54891