[PATCH] D54891: [RFC] Checking inline assembly for validity

Mike Hommey via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 26 18:18:07 PST 2018


glandium added a comment.

Assuming removing the `variadicOpsAreDefs` test completely (since I couldn't figure where it came from) still yields something that mostly works, it appears not to catch when the assembly writes to input operands. Examples of real code that had the problem:

- https://hg.mozilla.org/projects/nss/rev/09ab3310e71028dbdbf6846289cb4d3cea249534
- https://hg.mozilla.org/mozilla-central/rev/e471c532fd11


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54891/new/

https://reviews.llvm.org/D54891





More information about the llvm-commits mailing list