[PATCH] D54920: [ELF][MIPS] Handle mips in the OUTPUT_FORMAT directive

Simon Atanasyan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 27 00:40:04 PST 2018


atanasyan updated this revision to Diff 175409.
atanasyan added a comment.

- Return a boolean value indicating whether the name is MIPS N32 ABI or not from the `readBfdName` .

I think one of the problem is that there are multiple really different architectures and ABIs under the same `EM_MIPS` name. In particular, maybe it was better to introduce two different names `EM_MIPS` and `EM_MIPS_64` many years ago. In that case `ntradmips` (N32 ABI) could be describes like `{ELF32LEKind, EM_MIPS_64}`.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54920/new/

https://reviews.llvm.org/D54920

Files:
  ELF/ScriptParser.cpp
  test/ELF/emulation-mips.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54920.175409.patch
Type: text/x-patch
Size: 8210 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181127/5cbb25e9/attachment.bin>


More information about the llvm-commits mailing list