[PATCH] D54920: [ELF][MIPS] Handle mips in the OUTPUT_FORMAT directive

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/ScriptParser.cpp:426
+  uint16_t BfdEMachine;
+  StringRef BfdName;
+  std::tie(BfdEKind, BfdEMachine, BfdName) = readBfdName();
----------------
I don't think returning a bfd name makes sense. You should simply return a boolean value indicating whether it is MIPS N32 ABI or not.

But why MIPS always does too many things slightly differently? Do you really need to support both tradmips and ntradmips?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54920/new/

https://reviews.llvm.org/D54920