[PATCH] D54769: [FileCheck] New option -warn

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

In D54769#1308690 <https://reviews.llvm.org/D54769#1308690>, @jdenny wrote:

> In D54769#1308654 <https://reviews.llvm.org/D54769#1308654>, @dblaikie wrote:
>
> > You/others could checkin fixes as they find them rather than accumulating one large patch - then when it's close to done, you send out the patch to add the error to avoid regressions?
>
>
> Adding -warn now makes it easier for anyone to contribute to this cleanup and doesn't hurt anyone who doesn't care about it.


I wonder if `-allow-deprecated-dag-overlap` is a better model: an error that can be explicitly disabled.  The idea there was that over time we could rework the buggy tests, and when that's done, remove the option.  In the meantime all new tests will get complaints, which is what we want.

I think @dblaikie has a point; if we want to move to a new world with less-fallible tests, it's better for new FileCheck diags to be errors that are on-by-default, and explicitly disabled in the tests that we haven't managed to fix yet.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54769/new/

https://reviews.llvm.org/D54769