[PATCH] D54769: [FileCheck] New option -warn

Mon Nov 26 13:56:41 PST 2018

jdenny added a comment.

In D54769#1308654 <https://reviews.llvm.org/D54769#1308654>, @dblaikie wrote:

> > The usage we discussed is running with FILECHECK_OPTS="-warn" while developing/debugging tests, but normally you'd leave it off.  Does that address your concern?
>
> Not really - either everyone's using it and the tests are warning clean, or not everyone's using it (especially likely early on if it's opt-in) & the codebase has lots of warnings in it that make the feature hard to use practically by those who want to (because every time they sync and build, they'll get spurious warnings they have to clean up to be able to see their own warnings)

I imagined people would specify FILECHECK_OPTS="-warn" while running only the tests they're developing/debugging.  For example, they might combine with LIT_FILTER.  That is, they would only see warnings where they care about them.

Also, specific test suites that are expected to be warning-clean might want -warn in their config.  I was also thinking we'd eventually have a way to enable specific warnings or make them errors (like -Wfoo -Werror).  Others feel that's overkill for now because we don't have very many kinds of warnings.

> You/others could checkin fixes as they find them rather than accumulating one large patch - then when it's close to done, you send out the patch to add the error to avoid regressions?

Adding -warn now makes it easier for anyone to contribute to this cleanup and doesn't hurt anyone who doesn't care about it.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54769/new/

https://reviews.llvm.org/D54769