[PATCH] D54633: [NFC][AArch64] Split out backend features

[Oliver Stannard via Phabricator via llvm-commits]

olista01 added a comment.

Have you discussed these feature names with the GCC devs? I know we can change the user-facing names used by clang in in TargetParser, but it's easier for us if they match.

For the feature registers (ISAR6 and MMFR2), maybe we should just make these registers always available? These registers are all defined to read as all-zeroes in older architectures, which means no features described by that register are implemented. If we continue like this then we will have to add an extra feature to pretty much every new architectural feature for the ID register.



================
Comment at: lib/Target/AArch64/AArch64.td:36
+// UAO PState
+def FeaturePsUAO : SubtargetFeature<
+    "hasPsUAO", "HasPsUAO", "true",
----------------
Why is this up here, and not with the other v8.2A features?


https://reviews.llvm.org/D54633