[PATCH] D54633: [NFC][AArch64] Split out backend features

[Bryan Chan via Phabricator via llvm-commits]

bryanpkc added inline comments.


================
Comment at: lib/Target/AArch64/AArch64.td:99
+  "Enable FP16 FML instructions",
+  [FeatureFullFP16, FeatureID_AA64MMFR2_EL1]>;
 
----------------
Shouldn't this feature imply `FeatureID_ISAR6_EL1` instead of `FeatureID_AA64MMFR2_EL1`?


================
Comment at: lib/Target/AArch64/AArch64.td:236
     "dotprod", "HasDotProd", "true",
-    "Enable dot product support">;
+    "Enable dot product support", [FeatureID_AA64MMFR2_EL1]>;
+
----------------
Shouldn't this feature imply `FeatureID_ISAR6_EL1` instead of `FeatureID_AA64MMFR2_EL1`?




================
Comment at: lib/Target/AArch64/AArch64.td:245
+    "Enable v8.3-A Java Script FP conversion enchancement",
+    [FeatureFPARMv8, FeatureID_AA64MMFR2_EL1]>;
+
----------------
Shouldn't this feature imply `FeatureID_ISAR6_EL1` instead of `FeatureID_AA64MMFR2_EL1`?

IMO, the description should say `Javascript` or `JavaScript` to make it easier to grep.


================
Comment at: lib/Target/AArch64/AArch64.td:289
+    "Enable v8.4-A TLB range and maintenance Instructions",
+    [FeatureID_AA64MMFR2_EL1]>;
+
----------------
The architecture reference manual states that the ARMv8.4-TLBI feature is identified by `ID_AA64ISAR0_EL1.TLB`, not `ID_AA64MMFR2_EL1`. Is this discrepancy intentional?


https://reviews.llvm.org/D54633