[llvm] r347441 - [llvm-size] Use empty() and range-based for loop. NFC

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 21 16:44:17 PST 2018


Author: maskray
Date: Wed Nov 21 16:44:17 2018
New Revision: 347441

URL: http://llvm.org/viewvc/llvm-project?rev=347441&view=rev
Log:
[llvm-size] Use empty() and range-based for loop. NFC

Modified:
    llvm/trunk/tools/llvm-size/llvm-size.cpp

Modified: llvm/trunk/tools/llvm-size/llvm-size.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-size/llvm-size.cpp?rev=347441&r1=347440&r2=347441&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-size/llvm-size.cpp (original)
+++ llvm/trunk/tools/llvm-size/llvm-size.cpp Wed Nov 21 16:44:17 2018
@@ -869,19 +869,19 @@ int main(int argc, char **argv) {
   if (RadixShort.getNumOccurrences())
     Radix = RadixShort.getValue();
 
-  for (unsigned i = 0; i < ArchFlags.size(); ++i) {
-    if (ArchFlags[i] == "all") {
+  for (StringRef Arch : ArchFlags) {
+    if (Arch == "all") {
       ArchAll = true;
     } else {
-      if (!MachOObjectFile::isValidArch(ArchFlags[i])) {
+      if (!MachOObjectFile::isValidArch(Arch)) {
         outs() << ToolName << ": for the -arch option: Unknown architecture "
-               << "named '" << ArchFlags[i] << "'";
+               << "named '" << Arch << "'";
         return 1;
       }
     }
   }
 
-  if (InputFilenames.size() == 0)
+  if (InputFilenames.empty())
     InputFilenames.push_back("a.out");
 
   MoreThanOneFile = InputFilenames.size() > 1;




More information about the llvm-commits mailing list