[PATCH] D54690: [WebAssembly] Rename function types to signatures

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 20 18:15:49 PST 2018


aheejin marked 2 inline comments as done.
aheejin added inline comments.


================
Comment at: wasm/InputFiles.cpp:67
 uint32_t ObjFile::calcNewIndex(const WasmRelocation &Reloc) const {
   if (Reloc.Type == R_WEBASSEMBLY_TYPE_INDEX_LEB) {
+    assert(SigIsUsed[Reloc.Index]);
----------------
sbc100 wrote:
> I guess we should really rename the relocation type too R_WEBASSEMBLY_SIG_INDEX_LEB or R_WEBASSEMBLY_SIGNATURE_INDEX_LEB.   
Done. Linking spec change: https://github.com/WebAssembly/tool-conventions/pull/79


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D54690





More information about the llvm-commits mailing list