[PATCH] D54667: [CodeView] Emit proper debug info for ref-qualified member functions

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:2467-2469
+  auto I = TypeIndices.find({Ty, SubroutineTy});
+  if (I != TypeIndices.end())
+    return I->second;
----------------
rnk wrote:
> Every time we have to add a new method that routes around `getTypeIndex` and has to do its own `TypeIndices.find` check, I shed a tear. So far as I can tell, though, it's necessary.
Yes, I was sad about this.  One way we could have avoided it is if the DI Flags were on the pointer as well as (or instead of) being on the subroutine.  Then we could have handled it inside of `lowerTypePointer` the same way I did for the constness.


https://reviews.llvm.org/D54667