[PATCH] D54667: [CodeView] Emit proper debug info for ref-qualified member functions

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm, thanks!



================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1896
+  while (Index < ReturnAndArgs.size())
+    ArgTypeIndices.push_back(getTypeIndex(ReturnAndArgs[Index++]));
+
----------------
Nice.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:2467-2469
+  auto I = TypeIndices.find({Ty, SubroutineTy});
+  if (I != TypeIndices.end())
+    return I->second;
----------------
Every time we have to add a new method that routes around `getTypeIndex` and has to do its own `TypeIndices.find` check, I shed a tear. So far as I can tell, though, it's necessary.


https://reviews.llvm.org/D54667