[llvm] r347229 - [InterleavedLoadCombine] Fix warning unused variable

[Martin Elshuber via llvm-commits]

I agree that should work. But this debug message is not necessary at all.

Thanks

Am 20.11.18 um 00:11 schrieb David Blaikie:
> FWIW you can keep this for loop & write it like this:
>
> LLVM_DEBUG(for (auto &VI : InterleavedLoad)
> dbgs() << VI << "\n");
>
> I think? 
>
> On Mon, Nov 19, 2018 at 9:14 AM Martin Elshuber via llvm-commits
> <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
>
>     Author: martin.elshuber
>     Date: Mon Nov 19 09:11:48 2018
>     New Revision: 347229
>
>     URL: http://llvm.org/viewvc/llvm-project?rev=347229&view=rev
>     Log:
>     [InterleavedLoadCombine] Fix warning unused variable
>
>     Differential Revision: https://reviews.llvm.org/D52653
>
>
>     Modified:
>         llvm/trunk/lib/CodeGen/InterleavedLoadCombinePass.cpp
>
>     Modified: llvm/trunk/lib/CodeGen/InterleavedLoadCombinePass.cpp
>     URL:
>     http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/InterleavedLoadCombinePass.cpp?rev=347229&r1=347228&r2=347229&view=diff
>     ==============================================================================
>     --- llvm/trunk/lib/CodeGen/InterleavedLoadCombinePass.cpp (original)
>     +++ llvm/trunk/lib/CodeGen/InterleavedLoadCombinePass.cpp Mon Nov
>     19 09:11:48 2018
>     @@ -1119,8 +1119,6 @@ InterleavedLoadCombineImpl::findFirstLoa
>      bool InterleavedLoadCombineImpl::combine(std::list<VectorInfo>
>     &InterleavedLoad,
>                                              
>     OptimizationRemarkEmitter &ORE) {
>        LLVM_DEBUG(dbgs() << "Checking interleaved load\n");
>     -  for (auto &VI : InterleavedLoad)
>     -    LLVM_DEBUG(dbgs() << VI << "\n");
>
>        // The insertion point is the LoadInst which loads the first
>     values. The
>        // following tests are used to proof that the combined load can
>     be inserted
>
>
>     _______________________________________________
>     llvm-commits mailing list
>     llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
>     http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>

-- 
Martin Elshuber
Theobroma Systems Design und Consulting GmbH
Seestadtstraße 27 (Aspern IQ), 1220 Wien, Austria
Phone: +43 1 236 98 93-405, Fax: +43 1 236 98 93-9
http://www.theobroma-systems.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181120/233c88bc/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: OpenPGP digital signature
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181120/233c88bc/attachment-0001.sig>