[PATCH] D54684: [XRay] Move buffer extents back to the heap

[Dean Michael Berris via Phabricator via llvm-commits]

dberris marked an inline comment as done.
dberris added inline comments.


================
Comment at: compiler-rt/lib/xray/xray_buffer_queue.cc:59
+    atomic_uint64_t Extents;
+    unsigned char Storage[kCacheLineSize];
+  };
----------------
mboerger wrote:
> Shouldn't this be cache line size minus size of Extends?
Nope, the union is meant to ensure that the size of the member is the longer of these two elements.


Repository:
  rL LLVM

https://reviews.llvm.org/D54684