[PATCH] D54684: [XRay] Move buffer extents back to the heap

Marcus Boerger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 19 08:05:42 PST 2018


mboerger added inline comments.


================
Comment at: compiler-rt/lib/xray/xray_buffer_queue.cc:59
+    atomic_uint64_t Extents;
+    unsigned char Storage[kCacheLineSize];
+  };
----------------
Shouldn't this be cache line size minus size of Extends?


Repository:
  rL LLVM

https://reviews.llvm.org/D54684





More information about the llvm-commits mailing list