[PATCH] D54381: [llvm-exegesis] InstructionBenchmarkClustering::dbScan(): use llvm::SetVector<> instead of ILLEGAL std::unordered_set<>

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In https://reviews.llvm.org/D54381#1302626, @courbet wrote:

> > Two points i want to raise:
> > 
> > std::unordered_set<> should not have been used there in the first place. It is banned by the https://llvm.org/docs/ProgrammersManual.html#other-set-like-container-options
>
> Thanks Roman, I was not aware of that.


Thank you for the reviews!
Any chance you could stamp the last 3 remainig reviews so i could land everything? :)

>> There is no tests, so i'm not fully sure this is correct.
> 
> There are basic tests in unittests/tools/llvm-exegesis/ClusteringTests.cpp.
> 
>> Since it was unordered set, i guess there are zero restrictions on the order, and anything will be ok?
> 
> IIUC, SetVector is just more restrictive than unordered_set, so it should be fine.




Repository:
  rL LLVM

https://reviews.llvm.org/D54381