[PATCH] D54381: [llvm-exegesis] InstructionBenchmarkClustering::dbScan(): use llvm::SetVector<> instead of ILLEGAL std::unordered_set<>

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 19 02:27:11 PST 2018


courbet added a comment.

In https://reviews.llvm.org/D54381#1294614, @bobsayshilol wrote:

> I could be missing something, but I don't understand why `ToProcess` needs to be a set-like container since we're erasing elements as we go (ie the erased elements won't be duplicate checked on next insertion). We skip any that have been previously processed in the inner loop too, which seems like it's doing the same work the set would be doing.


IIRC, rangeQuery() can return points that need to be deduped against the already present ones.


Repository:
  rL LLVM

https://reviews.llvm.org/D54381





More information about the llvm-commits mailing list