[PATCH] D52025: [TargetLowering] Android has sincos functions

[Stephen Hines via Phabricator via llvm-commits]

srhines added a comment.

I just wanted to follow up here.

tl;dr - The patch is actually ok as-is, and does not need to be reverted.

At worst, this results in an extra call to sincos() (that then calls sin() followed by cos()) on older Android releases. For all newer releases, it will indeed use the optimized path. The only drawback to this patch is that it prevents new toolchains from being used to compile older versions of the Android platform (i.e. the core operating system code). This happens all the way up to Android Pie. Since AOSP has moved on, however, I don't feel that this is a big concern. Partners generally don't update toolchains for previously released OS versions, and newer OS versions (with newer toolchains) don't experience this problem.


Repository:
  rL LLVM

https://reviews.llvm.org/D52025