[PATCH] D52025: [TargetLowering] Android has sincos functions
Pirama Arumuga Nainar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 15 13:26:24 PST 2018
pirama added a comment.
Someone just pointed out to me that even in Android P [1], libm's sincos() just called sin() followed by cos() so this optimization won't be beneficial. It was changed in March 2018 [2] but is not a part of any release yet.
Unless there's any objection, let's revert this change and reintroduce it at a future time, enabling it from the next Android release forward.
[1] https://android.googlesource.com/platform/bionic/+/pie-release/libm/sincos.c
[2] https://android-review.googlesource.com/c/platform/bionic/+/681682/
Repository:
rL LLVM
https://reviews.llvm.org/D52025
More information about the llvm-commits
mailing list