[PATCH] D54586: [WebAssembly] Fix return type of nextByte

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 15 10:43:27 PST 2018


sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Target/WebAssembly/Disassembler/WebAssemblyDisassembler.cpp:124
   Size = 0;
   auto Opc = nextByte(Bytes, Size);
   if (Opc < 0)
----------------
I know its not really part of this change, but IIUC this is considered overuse of `auto` in the llvm style.  auto is only supposed to be used in cases where the type would otherwise be redundant (i.e. cast<>, dyn_cast<>, make_unique<> etc).


Repository:
  rL LLVM

https://reviews.llvm.org/D54586





More information about the llvm-commits mailing list