[PATCH] D54586: [WebAssembly] Fix return type of nextByte

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 15 09:32:50 PST 2018


tlively created this revision.
tlively added a reviewer: aheejin.
Herald added subscribers: llvm-commits, sunfish, jgravelle-google, sbc100, dschuff.

The old return type did not allow for correct error reporting and was
causing a compiler warning.


Repository:
  rL LLVM

https://reviews.llvm.org/D54586

Files:
  lib/Target/WebAssembly/Disassembler/WebAssemblyDisassembler.cpp


Index: lib/Target/WebAssembly/Disassembler/WebAssemblyDisassembler.cpp
===================================================================
--- lib/Target/WebAssembly/Disassembler/WebAssemblyDisassembler.cpp
+++ lib/Target/WebAssembly/Disassembler/WebAssemblyDisassembler.cpp
@@ -68,7 +68,7 @@
                                          createWebAssemblyDisassembler);
 }
 
-static uint8_t nextByte(ArrayRef<uint8_t> Bytes, uint64_t &Size) {
+static int nextByte(ArrayRef<uint8_t> Bytes, uint64_t &Size) {
   if (Size >= Bytes.size())
     return -1;
   auto V = Bytes[Size];


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54586.174227.patch
Type: text/x-patch
Size: 574 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181115/58956cac/attachment.bin>


More information about the llvm-commits mailing list